Dobe/fixnlstop #4092
Merged
Dobe/fixnlstop #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matriv
requested changes
Sep 22, 2016
| @@ -419,6 +419,9 @@ private Result emitRow(Row row) { | |||
| if (LOGGER.isTraceEnabled() && result != Result.CONTINUE) { | |||
| LOGGER.trace("phase={} side=right method=emitRow result={}", phaseId, result); | |||
| } | |||
| if (result==Result.STOP){ | |||
There was a problem hiding this comment.
white spaces around == and before {
| @@ -2,3 +2,4 @@ | |||
| cluster.name: dev | |||
| discovery.zen.ping.multicast.enabled: false | |||
| psql.enabled: true | |||
| stats.enabled: true | |||
There was a problem hiding this comment.
yes i think so, it does not hurt, and it is good for investigation
There was a problem hiding this comment.
My consideration is that we'll have these scheduled jobs running by default that might interfere with debugging, but we can switch if off if this is the case.
dobe
force-pushed
the
dobe/fixnlstop
branch
from
b78cbd8
to
0a69328
Compare
matriv
reviewed
Sep 22, 2016
| @@ -419,6 +419,9 @@ private Result emitRow(Row row) { | |||
| if (LOGGER.isTraceEnabled() && result != Result.CONTINUE) { | |||
| LOGGER.trace("phase={} side=right method=emitRow result={}", phaseId, result); | |||
| } | |||
| if (result == Result.STOP){ | |||
dobe
force-pushed
the
dobe/fixnlstop
branch
from
0a69328
to
1f0a119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.