Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose array_upper as array_length as well #7743

Merged
merged 3 commits into from
Oct 9, 2018
Merged

Expose array_upper as array_length as well #7743

merged 3 commits into from
Oct 9, 2018

Conversation

mfussenegger
Copy link
Member

  • User relevant changes are recorded in CHANGES.txt
  • Touched code is covered by tests
  • Documentation has been updated if necessary
  • CLA is signed

@mfussenegger
Avoid duplicate value calls in array_lower / array_upper
91c496a 
If the second argument is itself a function we would unnecessarily
evaluate it twice.
@mfussenegger mfussenegger requested a review from seut October 9, 2018 08:07
@seut
Copy link
Member

seut commented Oct 9, 2018

@mfussenegger please fix itest formatting errors

seut
seut approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@seut seut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

sql/src/main/java/io/crate/expression/scalar/ArrayUpperFunction.java Outdated
@@ -33,15 +33,17 @@

class ArrayUpperFunction extends Scalar<Integer, Object[]> {

public static final String NAME = "array_upper";
public static final String ARRAY_UPPER = "array_upper";
public static final String ARRAY_LENGTH = "array_length";
private FunctionInfo functionInfo;

public static FunctionInfo createInfo(List<DataType> types) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik this method is unused and can be removed

@mfussenegger mfussenegger added the ready-to-merge Let Mergify merge the PR once approved and checks pass label Oct 9, 2018
@mergify mergify bot merged commit 8680dc9 into master Oct 9, 2018
@mfussenegger mfussenegger deleted the j/array-length branch October 10, 2018 08:48
@mfussenegger mfussenegger mentioned this pull request Oct 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seut seut seut approved these changes

Assignees
No one assigned
Labels
ready-to-merge Let Mergify merge the PR once approved and checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mfussenegger @seut