Added PHP 5.6 and HHVM to travis.yml

[Nyholm]

I fixed the build matrix. We want to reduce the number of redundant runs

[coveralls]

Coverage decreased (-0.9%) when pulling cf4ccc6 on Nyholm:patch-1 into d1aa384 on craue:master.

[craue]

They are not really redundant but I'm fine with reducing them, while I'd still keep PHP 5.3 with symfony 2.1 to cover the minimum requirements.

You've chosen symfony 2.3 to run against all PHP versions because it's a LTS release?

Could you as well avoid calling php vendor/bin/coveralls -v in case of HHVM as it seems to not run well with code coverage analysis? I guess
sh -c 'if [ "${TRAVIS_PHP_VERSION}" != "hhvm" ]; then php vendor/bin/coveralls -v; fi;' should do.

[Nyholm]

Thank you for quick reply. Yes, it is because it is LTS.

I've updated the PR now.

[coveralls]

Coverage remained the same when pulling 7f23a1b on Nyholm:patch-1 into d1aa384 on craue:master.

[craue]

I just noticed that you removed quotes from some shell script variable values, but not all. Could you consistently quote them all again and squash the commits?

[craue]

I should've annotated specific lines initially. 😏 So please quote 2.3.* here and all other SYMFONY_VERSION values as well.

[craue]

Can you squash all commits into just one?

[coveralls]

Coverage remained the same when pulling a07a452 on Nyholm:patch-1 into d1aa384 on craue:master.

[Nyholm]

I just noticed that you removed quotes from some shell script variable values, but not all. Could you consistently quote them all again and squash the commits?

Sorry, I've miss-read you completely. (last minute fix before I left the office..)

I've updated the PR and squashed the commits.

Why do you want me to quote the SYMFONY_VERSION?

[craue]

Not SYMFONY_VERSION itself, but the values, just like you did. It's perfect now, thank you.

[Nyholm]

Not SYMFONY_VERSION itself, but the values, just like you did. It's perfect now, thank you.

Thank you for your patience with me =)

But why do you want the values quoted?

[craue]

Argh, one more typo here. 😆 Leading dash has to be removed.

[Nyholm]

Are you sure? I want it to be allowed to fail on HHVM or sf dev-master. If I remove the dash it will only be allowed to fail when using HHVM and sf dev-master.

See the build matrix on Travis. This is the intended result.

[craue]

This wasn't the case in the previous Travis runs, so I thought it's a typo. Why would you allow failures with master?

[Nyholm]

You can not rely on that symfony master branch is stable all the time. What if they introduce a bug that makes our tests fail?

[craue]

I'd rather take this as an indicator that the bundle might be broken by a change in the next Symfony release. But you're right, one will still notice this in the build details.

[craue]

But why do you want the values quoted?

These are strings and could contain spaces, so they should be quoted.

[coveralls]

Coverage remained the same when pulling d367c98 on Nyholm:patch-1 into d1aa384 on craue:master.

[Nyholm]

But why do you want the values quoted?

These are strings and could contain spaces, so they should be quoted.

Okey. Thanks.

[coveralls]

Coverage remained the same when pulling d367c98 on Nyholm:patch-1 into d1aa384 on craue:master.

[craue]

Thank you.

[Nyholm]

Thank you