Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PHP 5.6 and HHVM to travis.yml #139

Merged
merged 1 commit into from
Jul 14, 2014
Merged

Added PHP 5.6 and HHVM to travis.yml #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
31 changes: 25 additions & 6 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,38 @@ php:
- 5.3
- 5.4
- 5.5
- 5.6
- hhvm

env:
- SYMFONY_VERSION="2.1.*"
- SYMFONY_VERSION="2.2.*"
- SYMFONY_VERSION="2.3.*"
- SYMFONY_VERSION="2.4.*" SENSIO_FRAMEWORK_EXTRA_BUNDLE_VERSION="3.*"
- SYMFONY_VERSION="2.5.*" SENSIO_FRAMEWORK_EXTRA_BUNDLE_VERSION="3.*"
- SYMFONY_VERSION="dev-master" MIN_STABILITY="dev"

matrix:
allow_failures:
- php: hhvm
- env: SYMFONY_VERSION="dev-master" MIN_STABILITY="dev"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, one more typo here. 😆 Leading dash has to be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? I want it to be allowed to fail on HHVM or sf dev-master. If I remove the dash it will only be allowed to fail when using HHVM and sf dev-master.

See the build matrix on Travis. This is the intended result.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't the case in the previous Travis runs, so I thought it's a typo. Why would you allow failures with master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can not rely on that symfony master branch is stable all the time. What if they introduce a bug that makes our tests fail?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather take this as an indicator that the bundle might be broken by a change in the next Symfony release. But you're right, one will still notice this in the build details.

include:
- php: 5.3
env: SYMFONY_VERSION="2.1.*"
- php: 5.5
env: SYMFONY_VERSION="2.1.*"
- php: 5.5
env: SYMFONY_VERSION="2.2.*"
- php: 5.5
env: SYMFONY_VERSION="2.4.*" SENSIO_FRAMEWORK_EXTRA_BUNDLE_VERSION="3.*"
- php: 5.5
env: SYMFONY_VERSION="2.5.*" SENSIO_FRAMEWORK_EXTRA_BUNDLE_VERSION="3.*"
- php: 5.5
env: SYMFONY_VERSION="dev-master" MIN_STABILITY="dev"

before_script:
- sh travis_before_build.sh
- mkdir -p build/logs

script:
- phpunit --coverage-clover build/logs/clover.xml
- php vendor/bin/coveralls -v
- sh -c 'if [ "${TRAVIS_PHP_VERSION}" != "hhvm" ]; then php vendor/bin/coveralls -v; fi;'

notifications:
email:
on_success: always
Expand Down