Fix steps flow #243
Closed
Fix steps flow #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take this example. 3 steps. 1st step is not-skipped. 2nd step will be skipped. The form skips straight to step 3 because the second step is skipped even though the first isnt. Adding the break when the current step is false AND its still false after evaluation makes sense.
The refine current step is recursively sending the entire array back into its self. Why? it doesnt make sense. Whats happening is this. If you have an array of say 3 steps. If say the 1st step is set to be skipped, it will send the entire array back into itself and iterate over all steps again. This means if you have a form with 10 steps, it may iterate at a worst case 10 + 9 + 8 + 7 ... 1 times..
Trying to simplify this refining process
Flow fix
This was referenced Apr 20, 2016
|
Thank you, @jayesbe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove apparently useless lines.