Skip to content

Commit

Permalink
fix: remove a redundant/broken CI step
Browse files Browse the repository at this point in the history
Our current invocation of actions/checkout fetches the entire repository
history and the tags, and then this fetch line exists to apparently
shorten the history to depth 1. This isn't normally a big deal, but if
the most recent tag on a branch is non-annotated, this breaks git
describe on that branch. Current trunk is like this because of the
debian tag.

It's possible there's something I'm still not appreciating about what
this stop was intended to accomplish? Both changes to fetch depth were
added in a single commit in 449611f.
  • Loading branch information
rawlins committed May 8, 2023
1 parent 6d25397 commit a9a6e9e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ jobs:
with:
fetch-depth: 0 # all history
submodules: true
- run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
- name: Set up Python 3.7
uses: actions/setup-python@v4
with:
Expand Down

0 comments on commit a9a6e9e

Please sign in to comment.