tiles: some dialogs cannot be used/dismissed with mouse/touchpad/touchscreen #2528
Labels
ui
Issues related to any aspect of the UI
Comments
|
I take it that the report specifically is about this device in tablet mode, i.e. somehow a right click isn't working for these two popups via touch input. Is this correct? In which case can you clarify what the behavior of other popups is in terms of exiting via touch? Otherwise, I'm having trouble replicating this on mac, in that the two mentioned popups seem to have the same behavior as other popups (they exit on right click, and do respond to scrolling). |
|
I didn't realise that right click would dismiss them, I only tried left
click and assumed since selecting items in the help dialog didn't work
with left click, other touchpad buttons and touches wouldn't work.
I see now that isn't correct, sorry about that.
I also note that no right/left mouse clicks or touch events of any
kind can dismiss the dialogs for "Choose Game Seed", "Tutorial for
Dungeon Crawl", "Hints Mode for Dungeon Crawl" and "The Arena".
Only pressing Esc on the keyboard seems to cancel them.
The hints mode dialog has an "Esc - Quit" menu item though.
On the touchscreen though, the dialogs cannot be dismissed with a press
of any kind inside or outside the dialog.
Touch pressing or mouse/touchpad clicking outside the dialogs should
dismiss them, and maybe a long touch press inside should too.
It might be a good idea for the instructions on how to dismiss dialogs
to depend on the available input sources, so that people know the
appropriate interaction for their devices. Perhaps the main menu dialog
should also contain these instructions to set initial expectations.
Possibly when there are mouse/touchpad/touchscreen devices and screen
space available, maybe add a cancel button to dismiss dialogs easily.
The help subdialogs indeed respond to scrolling events from mice and
touchpad devices, but trying to scroll on the touchscreen by dragging
the finger up and down results in just a single downscroll when the
finger first touches the touchscreen and no upscroll.
…--
bye,
pabs
https://bonedaddy.net/pabs3/
|
rawlins
added a commit
that referenced
this issue
Apr 26, 2022
As noted in #2528, a bunch of main menu popups or submenus weren't correctly handling right clicks to exit. This should standardize the behavior. (Caveats: I still don't really understand why right click is best detected using `CK_MOUSE_CMD`, and I had do something a bit dodgy to get good handling of this for the seed/arena text entry boxes. Also, what would be much better is a click outside to close behavior, similar to how webtiles mouse handling works, which would probably address the touchscreen issues in that #2528.)
lesm232
added a commit
to itonges/crawl
that referenced
this issue
Apr 26, 2022
* fix: more consistent right click handling in main menu As noted in crawl#2528, a bunch of main menu popups or submenus weren't correctly handling right clicks to exit. This should standardize the behavior. (Caveats: I still don't really understand why right click is best detected using `CK_MOUSE_CMD`, and I had do something a bit dodgy to get good handling of this for the seed/arena text entry boxes. Also, what would be much better is a click outside to close behavior, similar to how webtiles mouse handling works, which would probably address the touchscreen issues in that crawl#2528.) * fix: improve arena cancel/end behavior * Remove all delays on cancelling, these are just confusing. * Show popup if any trials have occurred, even if no explicit t:1 flag has been set. I guess it may not be super informative with only one trial, but there's no other good way to see the log if you want it. This includes even the cancellation case, but only if at least one complete trial has occurred. * Add some more messaging around cancelling. I wonder if there are interesting stats the final popup could show? While testing this I noticed all sorts of other flaky behavior. Sampling: Sometimes cancelling still results in a delay with a blank screen. In console when I hit space during the first trial, there is a redraw that wipes out half the banner. Sometimes the cursor shows up in an ugly way (but sometimes it doesn't). Co-authored-by: advil <rawlins@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PLATFORM and OS or BROWSER:
Thinkpad X201 Tablet running Debian 12 bookworm, with GNOME shell 42 Wayland edition and the Debian crawl-tiles package version 2:0.28.0-1.
DCSS VERSION AND GAME INFORMATION:
0.28.0
DESCRIPTION:
The Thinkpad X201 Tablet is a dual-mode device. It can be in laptop mode with the keyboard visible or in tablet mode with the screen rotated around and locked to hide the keyboard. Sometimes I play Dungeon Crawl Tiles with the device in tablet mode. Unfortunately on this device the OpenGL drivers currently cause the "Crawl encountered errors during initialization:" dialog to appear (but this bug isn't about that issue). This dialog cannot be dismissed with the mouse/touchpad/touchscreen, only by pressing the Esc key on the keyboard. The same issue occurs with the Instructions/Help dialog. Both of these dialogs cannot be interacted with using the mouse/touchpad/touchscreen either; you need the keyboard to scroll the error dialog or select a section in the help. I expect that on touchscreen-only devices this means that the help dialog is completely inaccessible.
The text was updated successfully, but these errors were encountered: