Fix bug 11478: Movement-key actions and Wu Jian #778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In _move_player, the easy-open door let control flow continue through the function to behaviors that should only trigger upon moving. The most noticable is the Wu Jian processing, leading to the bug. The function could use some further simplifications, it's a bit spaghetti.
NormalPerson7
pushed a commit
to Vajrapani/X-Crawl
that referenced
this pull request
Jun 27, 2018
In _move_player, the easy-open door let control flow continue through the function to behaviors that should only trigger upon moving. The most noticable is the Wu Jian processing, leading to the bug. The function could use some further simplifications, it's a bit spaghetti. Closes crawl#778.
Floodkiller
pushed a commit
to Floodkiller/crawl
that referenced
this pull request
Jul 7, 2018
In _move_player, the easy-open door let control flow continue through the function to behaviors that should only trigger upon moving. The most noticable is the Wu Jian processing, leading to the bug. The function could use some further simplifications, it's a bit spaghetti. Closes crawl#778.
rawlins
pushed a commit
that referenced
this pull request
Jul 31, 2018
In _move_player, the easy-open door let control flow continue through the function to behaviors that should only trigger upon moving. The most noticable is the Wu Jian processing, leading to the bug. The function could use some further simplifications, it's a bit spaghetti. Closes #778. (cherry picked from commit b306ea2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In _move_player, the easy-open door let control flow continue through
the function to behaviors that should only trigger upon moving. The most
noticable is the Wu Jian processing, leading to the bug.
The function could use some further simplifications, it's a bit
spaghetti.