Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JAX-B dependencies to POM #196

Closed
YossiTamari opened this issue Mar 18, 2018 · 4 comments
Closed

Add JAX-B dependencies to POM #196

YossiTamari opened this issue Mar 18, 2018 · 4 comments
Assignees
Milestone

Comments

@YossiTamari
Copy link

From Java 9, JAX-B is not included in the JSE.
AbstractSiteMap imports javax.xml.bind.DatatypeConverter.
There is a workaround parameter for Java 9, but the correct solution is to add dependencies.
See also: https://docs.oracle.com/javase/9/migrate/#GUID-F640FA9D-FB66-4D85-AD2B-D931174C09A3, https://stackoverflow.com/a/43574427/9141985

@jnioche
Copy link
Contributor

jnioche commented Mar 19, 2018

Thanks @YossiTamari would you like to submit a PR?

@YossiTamari
Copy link
Author

Too much work... I just used --add-modules java.xml.bind locally. The lines that need to be added in the POM are in the SO answer I mentioned.

@jnioche
Copy link
Contributor

jnioche commented Mar 21, 2018

It would probably be better to avoid the use of this class altogether and rely on the core Java SE code. That would also be one less dependency that we'd have to deal with.

I have seen this java.time.format.DateFormatter.ISO_OFFSET_DATE_TIME being used as a replacement in this patch

@YossiTamari
Copy link
Author

Agreed. It will probably also simplify the code, by removing the W3C_NO_SECONDS_PATTERN section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants