Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JAX-B dependencies to POM #207

Merged
merged 2 commits into from
May 3, 2018
Merged

Add JAX-B dependencies to POM #207

merged 2 commits into from
May 3, 2018

Conversation

jnioche
Copy link
Contributor

@jnioche jnioche commented May 2, 2018

see #196
java.time.format.DateFormatter.ISO_OFFSET_DATE_TIME can't be used as a straightforward replacement so instead I opted to add the dependency

@jnioche jnioche added this to the 0.10 milestone May 2, 2018
kkrugler
kkrugler approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@kkrugler kkrugler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - maybe add something in CHANGES.txt?

@jnioche jnioche merged commit e25309d into master May 3, 2018
@jnioche jnioche deleted the 196 branch May 3, 2018 10:04
@jnioche
Copy link
Contributor Author

jnioche commented May 3, 2018

thanks @kkrugler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrugler kkrugler kkrugler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnioche @kkrugler