Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the project to use Java 11 #376

Merged

Conversation

sebastian-nagel
Copy link
Contributor

(implements / fixes #320)

@sebastian-nagel sebastian-nagel added this to the 1.3 milestone Jul 14, 2022
@aecio
Copy link
Contributor

aecio commented Jul 14, 2022

Is there any advantage of compiling and releasing the artifacts for the upcoming version 1.3 using Java 11 (as opposed to keeping it Java 8)? If not, what about merging this PR right after releasing version 1.3? This will give a few extra months for people still on Java 8, and we can start developing the next version using Java 11 features.

We could also change from version 1.x to 2.x to when we switch to Java 11. This will make clear that the release brings significant changes that might not be compatible. If for any reason, someone still needs Java 8, it would also be possible to release a 1.4 version with the needed features backported to Java 8.

@sebastian-nagel
Copy link
Contributor Author

sebastian-nagel commented Jul 15, 2022

Hi @aecio,

there is no hurry to force users of crawler-commons to use Java 11. Any objections?

Otherwise I'd move this PR and #320 to 1.4 (we can later decide how to name this milestone) and prepare for a release of 1.3...

Notes:

  • moved the updates to the changelog which do not belong to the Java 11 upgrade to a separate commit
  • for reference, see also the group discussion

@rzo1
Copy link
Member

rzo1 commented Jul 15, 2022

there is no hurry to force users of crawler-commons to use Java 11. Any objections?

Otherwise I'd move this PR and #320 to 1.4 (we can later decide how to name this milestone) and prepare for a release of 1.3...

+1

@aecio
Copy link
Contributor

aecio commented Jul 15, 2022

+1 to moving this PR to 1.4.
Then, in the release notes for 1.3 we can announce that 1.3 is planned to be the last release that supports Java 8.

@sebastian-nagel sebastian-nagel modified the milestones: 1.3, 1.4 Jul 19, 2022
@sebastian-nagel
Copy link
Contributor Author

Hi @aecio,

in the release notes for 1.3 we can announce that 1.3 is planned to be the last release that supports Java 8.

I'll put a note to the release announcement mail. The release notes should be final, and who knows whether we decide to delay the upgrade again.

Btw., I had a look at the dependents of crawler-commons: from the more popular ones, at least, heritrix3 is still based on JDK 8.

@rzo1
Copy link
Member

rzo1 commented Oct 18, 2022

Shall we move ahead with Java 11? ;)

It might be possible to build with Java 17 and provide Java 11 artifacts + if really needed, Java 8 artifacts via classifiers?

@rzo1
Copy link
Member

rzo1 commented Jan 17, 2023

@sebastian-nagel @aecio We will have Java 21 (LTS) this year. I guess, that we should move forward here, wdyt?

@aecio
Copy link
Contributor

aecio commented Jan 18, 2023

I think we should merge it now.

@sebastian-nagel
Copy link
Contributor Author

sebastian-nagel commented Jan 19, 2023

Ok, merge conflicts are resolved - will merge as soon as the checks have completed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the project to JDK11
3 participants