Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javadoc: ensure Javascript search is working, fixes #378 #380

Merged
merged 1 commit into from Aug 10, 2022
Merged

Javadoc: ensure Javascript search is working, fixes #378 #380

merged 1 commit into from Aug 10, 2022

Conversation

sebastian-nagel
Copy link
Contributor

Only for JDK / Java 11, pass the option --no-module-directories when building javadocs:

  • the issue Javadoc: ensure Javascript search is working #378 only affects Javadoc artifacts built with JDK 11 (but not JDK 8 and 17 - I didn't test other versions)
  • the option --no-module-directories breaks Javadoc builds on JDK 17, so it's made sure it's only called for JDK 11
  • according to JDK-8215291 the issue is fixed for JDK 12 and later

@sebastian-nagel
Javadoc: ensure Javascript search is working, fixes crawler-commons#378
9253f67 
- (only for JDK / Java 11) pass option --no-module-directories
@aecio aecio self-requested a review August 9, 2022 20:09
@sebastian-nagel sebastian-nagel added this to the 1.4 milestone Aug 10, 2022
@sebastian-nagel
Copy link
Contributor Author

Thanks, @rzo1 and @aecio! Going to merge...

@sebastian-nagel sebastian-nagel merged commit 08629d5 into crawler-commons:master Aug 10, 2022
sebastian-nagel added a commit that referenced this pull request Aug 10, 2022
@sebastian-nagel
Updates changelog for #378/#380, #377, #379
d3ccb55
@sebastian-nagel sebastian-nagel deleted the cc-378-javadoc-search branch August 10, 2022 08:20
sebastian-nagel added a commit that referenced this pull request Jul 12, 2023
@sebastian-nagel
Updates changelog for #376, #380, #401, #414, #425, #428, #422/#424, #…
a62bd80 
…114/#390/#430, #245/#360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aecio aecio aecio approved these changes

@rzo1 rzo1 rzo1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebastian-nagel @aecio @rzo1