-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the project to use Java 11 #376
Upgrade the project to use Java 11 #376
Conversation
Is there any advantage of compiling and releasing the artifacts for the upcoming version We could also change from version 1.x to 2.x to when we switch to Java 11. This will make clear that the release brings significant changes that might not be compatible. If for any reason, someone still needs Java 8, it would also be possible to release a 1.4 version with the needed features backported to Java 8. |
4b91f81
to
7ed977e
Compare
Hi @aecio, there is no hurry to force users of crawler-commons to use Java 11. Any objections? Otherwise I'd move this PR and #320 to 1.4 (we can later decide how to name this milestone) and prepare for a release of 1.3... Notes:
|
+1 |
+1 to moving this PR to 1.4. |
Hi @aecio,
I'll put a note to the release announcement mail. The release notes should be final, and who knows whether we decide to delay the upgrade again. Btw., I had a look at the dependents of crawler-commons: from the more popular ones, at least, heritrix3 is still based on JDK 8. |
Shall we move ahead with Java 11? ;) It might be possible to build with Java 17 and provide Java 11 artifacts + if really needed, Java 8 artifacts via classifiers? |
@sebastian-nagel @aecio We will have Java 21 (LTS) this year. I guess, that we should move forward here, wdyt? |
I think we should merge it now. |
Ok, merge conflicts are resolved - will merge as soon as the checks have completed. Thanks! |
(implements / fixes #320)