Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Robots.txt] Handle allow/disallow directives containing unescaped Unicode characters #401

Merged
merged 3 commits into from
May 11, 2023
Merged

[Robots.txt] Handle allow/disallow directives containing unescaped Unicode characters #401

merged 3 commits into from
May 11, 2023

Conversation

sebastian-nagel
Copy link
Contributor

fixes #389

  • use UTF-8 as default input encoding of robots.txt files
  • add unit test
    • test matching of Unicode paths in allow/disallow directives
    • test for proper matching of ASCII paths if encoding is not UTF-8 (and no byte order mark present)
  • add link to RFC 9309 to Javadoc class description
  • fix line wrapping in comments

@sebastian-nagel
[Robots.txt] Handle allow/disallow directives containing unescaped
2c2cb3b 
Unicode characters, fixes crawler-commons#389
- use UTF-8 as default input encoding of robots.txt files
- add unit test
  - test matching of Unicode paths in allow/disallow directives
  - test for proper matching of ASCII paths if encoding is not
    UTF-8 (and no byte order mark present)
@sebastian-nagel
Fix line wrapping in comments
be2d5c2
@sebastian-nagel
Add link to RFC 9309 to Javadoc class description
a395cfe
@sebastian-nagel sebastian-nagel added this to the 1.4 milestone Apr 24, 2023
@rzo1 rzo1 self-requested a review April 24, 2023 16:00
aecio
aecio approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@aecio aecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastian-nagel sebastian-nagel merged commit 79bef97 into crawler-commons:master May 11, 2023
2 checks passed
@sebastian-nagel
Copy link
Contributor Author

Thanks @rzo1 and @aecio for the reviews!

@sebastian-nagel sebastian-nagel deleted the cc-389-allow-disallow-unicode-paths branch June 16, 2023 15:38
sebastian-nagel added a commit that referenced this pull request Jul 12, 2023
@sebastian-nagel
Updates changelog for #376, #380, #401, #414, #425, #428, #422/#424, #…
a62bd80 
…114/#390/#430, #245/#360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aecio aecio aecio approved these changes

@rzo1 rzo1 rzo1 approved these changes

Assignees
No one assigned
Labels
robots
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

[Robots.txt] Handle allow/disallow directives containing unescaped Unicode characters
3 participants
@sebastian-nagel @aecio @rzo1