Improve sitemap parsing #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnioche
approved these changes
Apr 12, 2018
There was a problem hiding this comment.
Thanks @sebastian-nagel, looks good.
The formatting changed after running
mvn java-formatter:format
but this is not a big deal
|
Thanks! Applied code formatter to the lines changed/added by this PR. |
- ignore query part of URL to determine sitemap location prefix for URL validation, fixes crawler-commons#202 - resolve relative links in RSS feeds, fixes crawler-commons#203 - allow non-continuous content (containing XML entities or CDATA) when parsing links in RSS feeds, fixes crawler-commons#204 - extract links from <guid> elements in RSS feeds, fixes crawler-commons#201
sebastian-nagel
force-pushed
the
cc-201-202-203-204
branch
from
ff720e3
to
0ef7cf8
Compare
|
Thanks, @jnioche! Completed changelog, squashed commits and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR includes and is based on PR #200