Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of robots.txt unit tests #383

Conversation

sebastian-nagel
Copy link
Contributor

  • put lines of embedded robots.txt test files into separate code lines (except for empty lines)
  • apply code formatting template

This PR does not change anything except the formatting. Want to keep the formatting changes as separate PR to make the review of other PRs (to address #192 and #245) easier.

- put lines of embedded robots.txt test files
  into separate code lines (except for empty lines)
- apply code formatting template
- put lines of embedded robots.txt test files
  into separate code lines (except for empty lines)
@sebastian-nagel sebastian-nagel merged commit 3368cb5 into crawler-commons:master Oct 6, 2022
@sebastian-nagel
Copy link
Contributor Author

Thanks, @rzo1! Included some more robots.txt lines to be split over separate Java code lines.

@rzo1
Copy link
Member

rzo1 commented Oct 6, 2022

Thanks for the readability improvement, @sebastian-nagel

sebastian-nagel added a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants