-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching layer for GPG file contents #27
Conversation
Add cache to GPG backend
Fix indentation
next if !plain | ||
next if plain.empty? | ||
debug("GPG decrypt returned valid data") | ||
unless @data.has_key?(gpgfile) or !stale?(gpgfile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an 'and'? Looks like it will always return true if the file has been cached once. Or is that desired behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right, thanks very much! Adding that change to the branch...
+1 |
Caching layer for GPG file contents
Has a gem which includes this been released to rubygems? I'd love to take advantage of this without monkey patching my existing gem installation. |
$ gem search -r hiera-gpg *** REMOTE GEMS *** hiera-gpg (1.1.0) |
It doesn't look like 1.1.0 has the def stale. |
Oh, I was mistaken. Ignore me. :-p |
increase the version ;-) |
@crayfishx Is there any chance of doing a release soon? It would be very nice to get this feature without having pull the repo, build the gem, and then distribute that gem to our servers. |
This addresses issue #25