Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching layer for GPG file contents #27

Merged
merged 3 commits into from
Jul 5, 2013

Conversation

janstenpickle
Copy link
Contributor

This addresses issue #25

janstenpickle added 2 commits May 30, 2013 12:10
Add cache to GPG backend
Fix indentation
next if !plain
next if plain.empty?
debug("GPG decrypt returned valid data")
unless @data.has_key?(gpgfile) or !stale?(gpgfile)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an 'and'? Looks like it will always return true if the file has been cached once. Or is that desired behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right, thanks very much! Adding that change to the branch...

@csschwe
Copy link

csschwe commented Jul 1, 2013

+1

crayfishx added a commit that referenced this pull request Jul 5, 2013
Caching layer for GPG file contents
@crayfishx crayfishx merged commit 62b5ed6 into crayfishx:master Jul 5, 2013
@jkoppe
Copy link

jkoppe commented Sep 10, 2013

Has a gem which includes this been released to rubygems? I'd love to take advantage of this without monkey patching my existing gem installation.

@neoCrimeSecurity
Copy link

$ gem search -r hiera-gpg

*** REMOTE GEMS ***

hiera-gpg (1.1.0)

@jkoppe
Copy link

jkoppe commented Sep 10, 2013

It doesn't look like 1.1.0 has the

def stale
.

@neoCrimeSecurity
Copy link

Oh, I was mistaken. Ignore me. :-p

@bpesics
Copy link

bpesics commented Sep 24, 2013

increase the version ;-)

@phemmer
Copy link

phemmer commented Dec 20, 2013

@crayfishx Is there any chance of doing a release soon? It would be very nice to get this feature without having pull the repo, build the gem, and then distribute that gem to our servers.

@phemmer phemmer mentioned this pull request Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants