Fox Codacy issues

.eslintrc.json

@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "ecmaVersion": "5.1"
+  }
+}

gulp-tasks/assets-vendor.js

@@ -10,7 +10,7 @@ var gulp = require("gulp"),
   filter = require("gulp-filter"),
   order = require("gulp-order"),
   cleanCSS = require("gulp-clean-css"),
-  Bust = require('gulp-bust'),
+  Bust = require("gulp-bust"),
   merge = require("merge-stream"),
   gutil = require("gulp-util");
 

gulp-tasks/assets.js

@@ -2,10 +2,10 @@ var gulp = require("gulp"),
   readConfig = require("read-config"),
   config = readConfig("_config.yml"),
   autoprefixer = require("gulp-autoprefixer"),
-  Bust = require('gulp-bust'),
+  Bust = require("gulp-bust"),
   cleanCSS = require("gulp-clean-css"),
   concat = require("gulp-concat"),
-  flatten = require('gulp-flatten'),
+  flatten = require("gulp-flatten"),
   inject = require("gulp-inject"),
   order = require("gulp-order"),
   uglify = require("gulp-uglify"),

gulp-tasks/jekyll.js

@@ -15,7 +15,7 @@ gulp.task("jekyll-build", function (done) {
     .on("exit", function(code){
       gutil.log("Exited", gutil.colors.cyan("'spawn'"), "command", gutil.colors.magenta(bundle + " " + command.join(" ")));
       return done(code === 0 ? null : "ERROR: Jekyll process exited with code: " + code);
-    })
+    });
 });
 
 gulp.task("jekyll-rebuild", ["jekyll-build"], function () {

gulpfile.js

@@ -1,15 +1,15 @@
-var gulp = require('gulp'),
-  requireDir = require('require-dir'),
-  runSequence   = require('run-sequence');
+var gulp = require("gulp"),
+  requireDir = require("require-dir"),
+  runSequence   = require("run-sequence");
 
-requireDir('./gulp-tasks', { recurse: true });
+requireDir("./gulp-tasks", { recurse: true });
 
-gulp.task('build', function(done) {
-  runSequence('assets-build', 'assets-vendor-build', 'jekyll-build', done);
+gulp.task("build", function(done) {
+  runSequence("assets-build", "assets-vendor-build", "jekyll-build", done);
 });
 
-gulp.task('serve', function(done) {
-  runSequence('build', 'browser-sync', 'watch', done);
+gulp.task("serve", function(done) {
+  runSequence("build", "browser-sync", "watch", done);
 });
 
-gulp.task('default', ['build']);
+gulp.task("default", ["build"]);

src/_plugins/download_pages.rb

@@ -34,15 +34,15 @@ def generate(site)
         files = Dir[File.join(data_dir, 'neard.json')].reject { |p| File.directory? p }
         files.each do |file|
           data = JSON.parse(File.read(file))
-          next if !data.kind_of?(Hash)
+          next unless data.kind_of?(Hash)
 
           if File.basename(file) == 'neard.json'
             Jekyll.logger.debug "  Processing: #{data['name']}"
             data['releases'].each do |release|
               release['assets'].each do |asset|
                 release_filename = data['filename'] + '-' + release['version'] + asset;
                 release_url = site.config['github']['baseurl'] + '/' + data['repo'] + '/releases/download/v' + release['version'] + '/' + release_filename;
-                if !download_obj[release_filename]
+                unless download_obj[release_filename]
                   site.pages << DownloadPage.new(site, site.source, File.join(download_dir, release_filename), release_filename, release_url)
                   for checksum in checksums
                     site.pages << DownloadPage.new(site, site.source, File.join(download_dir, release_filename + '.' + checksum), release_filename + '.' + checksum, release_url + '.' + checksum)
@@ -64,7 +64,7 @@ def generate(site)
             release['versions'].each do |version|
               module_filename = data['filename'] + '-' + version['name'] + '-' + release['name'] + '.' + version['ext'];
               module_url = site.config['github']['baseurl'] + '/' + data['repo'] + '/releases/download/' + release['name'] + '/' + module_filename;
-              if !download_obj[module_filename]
+              unless download_obj[module_filename]
                 site.pages << DownloadPage.new(site, site.source, File.join(download_dir, module_filename), module_filename, module_url)
                 for checksum in checksums
                   site.pages << DownloadPage.new(site, site.source, File.join(download_dir, module_filename + '.' + checksum), module_filename + '.' + checksum, module_url + '.' + checksum)

src/_plugins/filesize.rb

@@ -9,7 +9,7 @@ def filesize(value)
 
       begin
         value = value.to_f
-      rescue Exception => e
+      rescue => e
         puts "#{e.class} #{e}"
         return value
       end

src/_plugins/release_pages.rb

@@ -23,7 +23,7 @@ def initialize(site, base, dir, release, changelog_md, upgrade_md)
       self.data['release'] = release
       self.data['changelog'] = changelog_md
       self.data['upgrade'] = upgrade_md
-      self.data['github_api'] = JSON.load(ReleasePageUtils.getContentFromUrl(site, github_url, release['version'] + '.json'))
+      self.data['github_api'] = JSON.load(ReleasePageUtils.get_content_from_url(site, github_url, release['version'] + '.json'))
       if File.basename(dir) == 'latest'
         self.data['sitemap'] = { "priority" => "0.8", "changefreq" => "daily" }
       else
@@ -58,13 +58,13 @@ def generate(site)
 
       if site.layouts.key? 'release'
         ## Download CHANGELOG.md
-        changelog_md = ReleasePageUtils.getContentFromUrl(site,
+        changelog_md = ReleasePageUtils.get_content_from_url(site,
           'https://raw.githubusercontent.com/crazy-max/neard/master/CHANGELOG.md',
           'changelog.md'
         )
 
         ## Download UPGRADE.md
-        upgrade_md = ReleasePageUtils.getContentFromUrl(site,
+        upgrade_md = ReleasePageUtils.get_content_from_url(site,
           'https://raw.githubusercontent.com/crazy-max/neard/master/UPGRADE.md',
           'upgrade.md'
         )
@@ -73,7 +73,7 @@ def generate(site)
 
         release_dir = site.config['release_dir'] || 'release'
         data_dir = File.join(site.source, (site.config['data_dir'] || '_data'))
-        data = JSON.load(File.open("#{data_dir}/neard.json"))
+        data = JSON.load(File.read("#{data_dir}/neard.json"))
         data['releases'].each do |release|
           site.pages << ReleasePage.new(site, site.source, File.join(release_dir, release['version']), release, changelog_md, upgrade_md)
         end
@@ -86,7 +86,7 @@ def generate(site)
   end
 
   class ReleasePageUtils
-    def self.getContentFromUrl(site, url, filename)
+    def self.get_content_from_url(site, url, filename)
       result = ''
 
       tmp_dir = File.join('tmp', 'neard')

src/js/actions/progressbar.js

@@ -6,7 +6,7 @@ var actionProgressbar = {
     }
 
     $(".progressbar-fill").delay(1000).queue(function () {
-      time = $(this).attr("data-time") || 2;
+      var time = $(this).attr("data-time") || 2;
       $(this).css("width", "100%").css("transition", "width " + time + "s ease-in-out");
     });
   }

src/js/actions/screenshots.js

@@ -8,10 +8,10 @@ var actionScreenshots = {
 
     gallery.justifiedGallery({
       rowHeight : 160,
-      lastRow : 'nojustify',
+      lastRow : "nojustify",
       margins : 6,
       border: 6
-    }).on('jg.complete', function() {
+    }).on("jg.complete", function() {
       lightGallery(gallery[0], {
         thumbnail: true,
         animateThumb: false,