Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does crc undo the file ownership & mode changes made to /etc/hosts after it's deleted? #683

Closed
morningspace opened this issue Oct 3, 2019 · 4 comments

Comments

@morningspace
Copy link

General information

  • OS: macOS
  • Hypervisor: VirtualBox / hyperkit
  • Did you run crc setup before starting it (Yes)?

CRC version

# Put the output of `crc version`
version: 1.0.0-beta.5+f2aa58c
OpenShift version: 4.1.14 (embedded in binary)

Host Operating System

# put the output of `sw_vers` in case of Mac
ProductName:	Mac OS X
ProductVersion:	10.13.6
BuildVersion:	17G3025

Steps to reproduce

  1. ls -l /etc/hosts
-r-xr--r--  1 root  wheel  1999 Oct  3 13:47 /etc/hosts
  1. oc setup, oc start, ls -l /etc/hosts
-rw-r--r--  1 morningspace  wheel  1999 Oct  3 14:06 /etc/hosts
  1. oc stop, oc delete, ls -l /etc/hosts
-rw-r--r--  1 morningspace  wheel  1999 Oct  3 14:06 /etc/hosts

Expected

The file ownership & mode can be undone after oc delete

Actual

The file ownership & mode remains which is made during the time when oc setup

@morningspace
Copy link
Author

I can understand to undo the change will cause the rerun of crc setup and re-apply the ownership and mode changes to /etc/hosts. However, people may want to get their env back to a clean state. So, at least it would be nice if there's an option for people to choose.

@gbraad
Copy link
Contributor

gbraad commented Oct 3, 2019 via email

@morningspace
Copy link
Author

@gbraad That's awesome... where can I find the WIP PR? Thanks...

@gbraad
Copy link
Contributor

gbraad commented Oct 3, 2019

Duplicate of #507
See: #651

@gbraad gbraad closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants