-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload qe images when code merged to main #4369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extend https://github.com/crc-org/crc/blob/main/.github/workflows/windows-artifacts.yml#L58 as that is executed on push to main as well.
So we do not build images several times on push.
In this case you just add an extra step with condition on push event and re-tag images to next-OS-ARCH or dev-OS-ARCH just take into account:
the task is composing the version with v as so it would expect i.e. vnext-OS-ARCH
As we also need to plan move crc-e2e task to ci-defintions we can re think on that v composition...meaning you can leave the tag as i.e. next-OS-ARCH, then we would need to adapt the version value accordingly.
WDYT?
@adrianriobo Hi, For the windows artifacts action(https://github.com/crc-org/crc/blob/main/.github/workflows/windows-artifacts.yml), I don't get your suggestion: |
b16a593
to
8c3965b
Compare
@adrianriobo I have added V in the tag, like |
4737620
to
d4d7c16
Compare
f7f15e0
to
fbd7378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change a bit the commit message, something like:
"[QE] Push qe oci image to quay on every merge to main.
This commit will push qe oci images to quay tagged as next, so we can use the latest changes on e2e and integration code to be used across all our CI systems"
In any case LGTM to me
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianriobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit will push qe oci images to quay tagged as next, so we can use the latest changes on e2e and integration code to be used across all our CI systems
fbd7378
to
ad54d2d
Compare
New changes are detected. LGTM label has been removed. |
#4368