-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install-config.yaml: Add image-registry, build and deployment config capability #807
install-config.yaml: Add image-registry, build and deployment config capability #807
Conversation
…capability 4.14 add more capability like image-registry, build and deployment as addon which can be added on top of `None`. By default since we are using `None` those capabilities need to be added explicitly to have it part of cluster since we are providing these features before. fixes: crc-org#806
90bc403
to
1c092af
Compare
Fixes #806 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to list all the available capabilities? Could we have a test somewhere which would check the list of capabilities known to snc VS the list of capabilities available in the cluster, and warn us or error out when they are different? This would allow us to catch this kind of issues early.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Cluster operators within the capabilities
|
4.14 add more capability like image-registry, build and deployment as addon which can be added on top of
None
. By default since we are usingNone
those capabilities need to be added explicitly to have it part of cluster since we are providing these features before.