Auto brightness fix for oneplus 7 series #694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AOSPA: * Bugfix for when mProperty.setValue() is not called due to the animation amount being smaller than EPSILON (BrightnessSynchronizer@L52) Change-Id: I99ca859e5c021992bfbeece3bfe011df4e87be36 Signed-off-by: Mukesh Singh <mks22584@gmail.com>
The brightness slider is animated at a fixed max duration of 3000ms. If the brightness ramp rate is reduced to a value that is much lower than the default rate, the brightness slider animation can be considerably out of sync with the screen brightness transitions. Override the slider animator duration scale by the ratio of the default ramp rate to the actual rate in use. The maximum scale is clamped to 3x. Note that the purpose is not to make the slider perfectly in sync with the screen, as the original design was not like that either. Signed-off-by: Chenyang Zhong <zhongcy95@gmail.com> Change-Id: I980a8976d1d8e6fe9c295be9a06ee305a66c9448 Signed-off-by: Mukesh Singh <mks22584@gmail.com>
neobuddy89
requested changes
Jul 21, 2021
Isn't it device specific overlay ? |
|
How do you overlay it if it's not present in source? Moreover, the code compilation will fail since you are looking for the undefined symbol in source whether or not defined in device tree . |
Ahh ! My bad, I've missed commits. |
|
Added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.