Revert #167 to avoid race on Linux. #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate bot
added a commit
to kairos-io/provider-kairos
that referenced
this pull request
Dec 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/creack/pty](https://togithub.com/creack/pty) | require | patch | `v1.1.20` -> `v1.1.21` | --- ### Release Notes <details> <summary>creack/pty (github.com/creack/pty)</summary> ### [`v1.1.21`](https://togithub.com/creack/pty/releases/tag/v1.1.21) [Compare Source](https://togithub.com/creack/pty/compare/v1.1.20...v1.1.21) #### What's Changed - Tests cleanup by [@​creack](https://togithub.com/creack) in [creack/pty#173 - Revert [#​167](https://togithub.com/creack/pty/issues/167) to avoid race on Linux. by [@​creack](https://togithub.com/creack) in [creack/pty#177 **Full Changelog**: creack/pty@v1.1.20...v1.1.21 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
4 tasks
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @sio I am reverting the nonblock PR, it causes a race on Linux, randomly blocking on read/write and randomly failing to set/get size.
Adding
-count=100to the test consistently reproduces the issue. Using.Fd()fixes the issue.I would rather keep your changes and avoid
.Fd(), but it would need to work consistently, if you have any idea, let me know.cc @kr if you have any ideas too.