Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deprecate py35 and below #380

Closed
wants to merge 2 commits into from

Conversation

mlshapiro
Copy link
Contributor

Can we do this? Tests are already showing we need to

@mlshapiro mlshapiro changed the base branch from master to develop April 2, 2020 21:15
@jmilloy
Copy link
Collaborator

jmilloy commented Apr 2, 2020

I think we can deprecate python 3.5 even if we can't deprecate python 2. When I asked about this in the fall Matt said we needed to keep python 2 support.

(I had to allow pyproj 2.2 in order to run the setup.py on my machine with python 2. I made that change this morning.)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 91.677% when pulling ffd53fc on feature/deprecate-py35-and-below into 9076d57 on develop.

@coveralls
Copy link

coveralls commented Apr 2, 2020

Coverage Status

Coverage decreased (-0.2%) to 91.677% when pulling ffd53fc on feature/deprecate-py35-and-below into 9076d57 on develop.

@mlshapiro
Copy link
Contributor Author

ah ok, so in that case, we can say python >= 3.6, or py 2.7. Too bad we can't deprecate py 2. If thats the case, xarray deprecated python 2 in 0.12, so we'll have to keep it at 0.11.

I'll close this PR and see if I can get the tests to work with setup.py as is

@mlshapiro mlshapiro closed this Apr 2, 2020
@mlshapiro mlshapiro deleted the feature/deprecate-py35-and-below branch April 2, 2020 22:06
@mpu-creare
Copy link
Contributor

Late to the party, but agree with everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants