Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup select sources #382

Merged
merged 2 commits into from Apr 3, 2020
Merged

cleanup select sources #382

merged 2 commits into from Apr 3, 2020

Conversation

jmilloy
Copy link
Collaborator

@jmilloy jmilloy commented Apr 3, 2020 •
edited

  • Moves shared_coordinates and is_source_coordinates_complete to SMAPCompositor
  • Moves set interpolation (and set native_coordinates) from iteroutputs to to select_sources
  • couple of bugfixes

Easy one. In preparation for further compositor work.

@jmilloy
MAINT: Moves compositor sources handling from iteroutputs to select_s…
fae95f8 
…ources, and moves SMAP shared_coordinates optimizations to SMAPCompositor subclass.

Set source interpolation in BaseCompositor.select_sources
Set SMAPSource native_coordinates in SMAPCompositor.select_sources
BUGFIX: set source interpolation if the source has interpolation trait (self -> s typo)
BUGFIX: SMAPDatefolder shared_coordinates need to be a trait so that it can be set by SMAP.
@jmilloy
FIX: some coord select tests still using Array data instead of source.
5af6afe
@jmilloy jmilloy requested a review from mpu-creare April 3, 2020 17:32
@jmilloy jmilloy self-assigned this Apr 3, 2020
@jmilloy jmilloy added this to In progress in 2.0.0 Release via automation Apr 3, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 91.939% when pulling 5af6afe on feature/cleanup-select-sources into 5adaaf0 on develop.

mpu-creare
mpu-creare approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@mpu-creare mpu-creare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Jeff.

@mpu-creare mpu-creare merged commit 1d1551c into develop Apr 3, 2020
2.0.0 Release automation moved this from In progress to Done Apr 3, 2020
@mpu-creare mpu-creare deleted the feature/cleanup-select-sources branch April 3, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpu-creare mpu-creare mpu-creare approved these changes

Assignees

@jmilloy jmilloy

Labels
None yet
Projects
No open projects
2.0.0 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmilloy @coveralls @mpu-creare