Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BooleanFilter inputFalse value should be false #1

Closed
andreasplesch opened this issue Sep 4, 2017 · 2 comments
Closed

BooleanFilter inputFalse value should be false #1

andreasplesch opened this issue Sep 4, 2017 · 2 comments

Comments

@andreasplesch
Copy link
Contributor

https://github.com/create3000/x_ite/blob/master/src/x_ite/Components/EventUtilities/BooleanFilter.js#L110
assigns inputFalse = true but the consensus seems to be that the value should be false.

http://web3d.org/pipermail/x3d-public_web3d.org/2017-September/007436.html and thread has a discussion.

Looking for a simple test scene.

@andreasplesch
Copy link
Contributor Author

http://x3dom-booleanfilter.glitch.me/BooleanFilter_test.x3d

is a simple test scene which is tested with other x3d browsers. Clicking on the upside down cone should turn off the point light. If desired I can submit a trivial PR for BooleanFilter:

			if (value)
				this .inputTrue_ = true;
		
			else
				this .inputFalse_ = false; //was true

@andreasplesch
Copy link
Contributor Author

Thanks.
10fb3fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant