Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC 4.0: Use capital letters for the third level numbering #1240

Closed
wants to merge 1 commit into from
Closed

CC 4.0: Use capital letters for the third level numbering #1240

wants to merge 1 commit into from

Conversation

jodeebrowm
Copy link
Contributor

@jodeebrowm jodeebrowm commented Jul 15, 2022 •
edited by TimidRobot
Loading

Fixes

Fixes creativecommons/cc-legal-tools-app#286 by @jodeebrowm

Description

Capitalise the letters used in the items of third level enumerations,
e.g. (a)(1)(B) instead of (a)(1)(b). This is consistent with the HTML
version of the licenses and only affects the labels of the enumeration
not the references inside the text (which are already upper case).

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@jodeebrowm
CC 4.0: Use capital letters for the third level numbering
af666a5 
Capitalise the letters used in the items of third level enumerations,
e.g. (a)(1)(B) instead of (a)(1)(b).  This is consistent with the HTML
version of the licenses and only affects the labels of the enumeration
not the references inside the text (which are already upper case).
@jodeebrowm jodeebrowm requested review from a team and possumbilities and removed request for a team July 15, 2022 07:08
@jodeebrowm jodeebrowm mentioned this pull request Jul 15, 2022
Open
1 task
@TimidRobot TimidRobot self-assigned this Jul 15, 2022
@TimidRobot TimidRobot removed the request for review from possumbilities July 15, 2022 14:21
@TimidRobot
Copy link
Member

TimidRobot commented Jul 15, 2022 •
edited
Loading

@jodeebrowm thank you for taking the time to do this work!! I agree that there should be consistency between formats.

However, I am going to close this pull request because:

Please let me know if:

  1. you'd like to open an issue in creativecommons/cc-legal-tools-app noting the inconsistency
  2. or I can create an issue and credit you in the description

I moved issue to new repo creativecommons/cc-legal-tools-app#286

@TimidRobot TimidRobot added the ⛔️ status: discarded Will not be worked on label Jul 15, 2022
@TimidRobot TimidRobot closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TimidRobot TimidRobot

Labels
⛔️ status: discarded Will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CC 4.0 plain text licenses: third level numbering in lower case but referencing in upper case
2 participants
@jodeebrowm @TimidRobot