Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to top button not working on small screens once the user has reached footer. #182

Closed
techievivek opened this issue Feb 21, 2020 · 8 comments · Fixed by #185
Closed
Assignees
Labels
good first issue New-contributor friendly help wanted Open to participation from the community

Comments

@techievivek
Copy link
Contributor

techievivek commented Feb 21, 2020

Describe the bug

Back to top button is not working for the small screen(around 700px or less) once the user navigates to the footer of the page.

To Reproduce

Steps to reproduce the behaviour:

  1. Visit any page which has Back to top button visible, scroll down to the footer of the page and try clicking on the Back to top button, it will get stuck.

Expected behavior

It must take back to top.

Screenshots

back to top

Desktop

  • OS: Ubuntu Linux
  • Browser : Firefox

Smartphone

  • Device: One plus 7t
  • OS: Android 10
  • Browser : Google chrome

Additional context

After observing for a while whenever the text content of the footer gets in line with the Back to top button it stops working. And that is the reason it works smoothly on large screens as the text content of footer never comes in the way.

@techievivek
Copy link
Contributor Author

techievivek commented Feb 21, 2020

@kgodey Whenever Back to top button floats over footer part, It stops working for Small screen devices, I have verified this from my phone and also by minimizing the browser on mine laptop.

@kgodey kgodey added good first issue New-contributor friendly help wanted Open to participation from the community labels Feb 21, 2020
@kgodey
Copy link
Member

kgodey commented Feb 21, 2020

Thanks for reporting this @techievivek

@hedonhermdev
Copy link
Contributor

Hey! I would like to work on this issue.

@techievivek
Copy link
Contributor Author

@hedonhermdev please go ahead. To edit the content you will have to go to templates folder and then into layout.html file.

@hedonhermdev
Copy link
Contributor

Hey, I think that this could be fixed by changing the z-index css property of the back-to-top button. But I realised that the CSS files are built and are not part of the repository. How should I modify the css file that is built?

@kgodey
Copy link
Member

kgodey commented Feb 21, 2020

@techievivek
Copy link
Contributor Author

@hedonhermdev Yeah, that's perfect.

@hedonhermdev
Copy link
Contributor

Waiting for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New-contributor friendly help wanted Open to participation from the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants