-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview images and page descriptions for social media #100
Comments
I can handle this. Please may I proceed? |
Sure @SamOdum, I see you've commented on a couple of other issues on this repo as well, please pick one issue at a time so that others have a chance too. Let me know which one you want to tackle first and I'll mark that one as in progress. |
Thank you for responding. May I start with this one? |
Go ahead. |
Hi @kgodey ! Pleace may i work with you on this ? |
@chimenekouomogne This is already in progress, there is a pull request for it. |
@kgodey mam If this is not fixed I will love to work on this one. |
@techievivek go ahead |
@kgodey hello mam, I tried solving this issue but since all the blog posts need not have image how will we able to show the featured image for same, I think @SamOdum idea is one we can go with. |
We should use the first image on the page/blog post if it exists, otherwise we should not have a featured image at all. |
@kgodey so in case if no images are part of blog/page can we use cc logo. So that it looks genuine and better while sharing. |
I think it's best to skip the featured image entirely if there's no image in the post/page. |
@kgodey hello mam, I have almost worked on this issue but just some queries before I start a pull request.
|
@kgodey hello mam, should i create a pull request and then you will check it out? |
|
@kgodey hello mam, I have added both striphtmltags and markdown-excerpt plugin to the project so that I can convert body content into plain text and then just get the first line content using markdown-excerpt.
This is the content of file .lektorproject after I run the above command. Progress till nowI have just added the image functionality, i.e. it will select an image if there.
Please suggest me how do I proceed with this? |
@kgodey hello mam, please look into this. |
@techievivek please create a PR so that I can see why the error is happening. |
@kgodey mam, I have created a PR, please look into it. |
@kgodey hello mam, did u have a look at it? |
Not yet, it will take me a couple more days, sorry. |
@kgodey Ok mam, sure. I am looking at other repo under CC. |
@kgodey Mam, can we just show the image (first one in the post) and the title while sharing on different platform.( we can skip the description part). |
@kgodey mam please take a look at above suggestion. |
@techievivek I think GitHub ate my last comment because I definitely replied to this :/ Yes, we can skip the description for now. Could you make a separate GitHub issue for adding the description once this is merged? We can tackle that separately. |
@kgodey I have created a new PR, please have a look. And I will add a new issue for the description part. |
Hi -- just a suggestion: Blog post pages on the open source blog don't appear to be optimized well for Twitter and Facebook (etc.) to be able to fetch and display image and description previews. See attached screenshots
The text was updated successfully, but these errors were encountered: