-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimised blog posts for social sharing #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SamOdum Could you share a screenshot of a social media preview with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SamOdum I don't think adding new fields that duplicate content and images make sense, can you find a way to use existing attachments and text?
@SamOdum do you still plan to work on this pull request? |
Yes please.
…On Wed, 13 Nov 2019 at 00:50, Kriti Godey ***@***.***> wrote:
@SamOdum <https://github.com/SamOdum> do you still plan to work on this
pull request?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#127?email_source=notifications&email_token=AK7PAKGTPVTSGMMY6X6JL2DQTM6KRA5CNFSM4I7MIQVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED4LO3I#issuecomment-553170797>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK7PAKCUUVAV3PIVIUPTB23QTM6KRANCNFSM4I7MIQVA>
.
|
@SamOdum okay thanks, please address the latest PR feedback I left. |
@SamOdum thank you for your work on this! This issue has been fixed by other PRs, so I'm going to close this. |
Fixes 100
Description
Updated blog-post.ini and blog-post.html to enable optimised social media sharing.
Checklist:
Update index.md
).master
branch of the repository.visible errors.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.