-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import remaining blog posts from the labs repository. #43 #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could you replace
(http://creativecommons.github.io/tech-blog-archives/more-xmp-toolkit-plugs/)
style links with just (/tech-blog-archives/more-xmp-toolkit-plugs/
)? the domain and protocol do not need to be in links within the same site. - Could you put the method you used to ensure that all blog posts and images were ported over in the PR description?
Also, has the |
No, I thought I would do that after the draft PR would merge. Just to confirm adding the following would do?
|
I would use |
category need to be on a separate line in |
I believe so, I haven't used it before and I'm going off the documentation I linked above. |
I can make a script to do it.
|
Yeah, that looks right. You could test it by trying to read the values in the template like the documentation shows. |
yes, I have tested it using the Lektor documentation example and it is working. |
@@ -1,6 +1,7 @@ | |||
title: Getting started with hacking on The List | |||
--- | |||
author: Matt Lee | |||
categories: | |||
Lee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some kind of error in the script. This post should have "development" as a category and nothing else (see: original file: https://raw.githubusercontent.com/creativecommons/labs/gh-pages/_posts/2014-12-15-getting-started-hacking-on-the-list.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only file with this error. I forgot to add the categories to it after it was merged in #43 and therefore the script not worked properly on it. I will correct it.
…-started-with-hacking-on-the-list/contents.lr
this looks good, I've verified with @makkoncept on Slack that the number of blog posts ported over match up. |
Description
I have used this python script to automate the conversion of HTML files(in _posts) to corresponding directories with contents.lr file inside. The script looks for the images referenced in HTML files in img directory and copies them to the folder. The files whose images were not find are printed to the console so that we can check manually in other places. Two markdown files were remaining which were ported manually.
Images corresponding to the following html files are not available:
Other information
Checklist:
Update index.md
).master
branch of the repository.visible errors.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.