Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus label to build info #319

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

creativeprojects
Copy link
Owner

Add the profile label, and any other label from the configuration to the resticprofile_build_info metric

Fixes: #318

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9eba431) 78.94% compared to head (1ae0396) 78.94%.

Files Patch % Lines
monitor/prom/progress.go 0.00% 4 Missing ⚠️
monitor/prom/metrics.go 97.37% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   78.94%   78.94%   -0.01%     
==========================================
  Files         101      101              
  Lines        9717     9713       -4     
==========================================
- Hits         7671     7667       -4     
  Misses       1764     1764              
  Partials      282      282              
Flag Coverage Δ
unittests 78.94% <88.37%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Javex
Copy link

Javex commented Feb 15, 2024

Amazing! You're quick! I just rolled it out on one server and ran it. No more log errors from node_exporter! I will keep it on just one server and monitor this PR for any issues that might come up until a new version is released.

Thanks for such a quick fix, that's a massive help!

@creativeprojects creativeprojects merged commit 233e4b8 into master Feb 15, 2024
9 checks passed
@creativeprojects creativeprojects deleted the add-label-to-build-info branch February 15, 2024 19:19
@creativeprojects creativeprojects added this to the v0.26.0 milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants