Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add imageurl field in oob issuance and verification #64

Merged
merged 2 commits into from
Feb 26, 2024
Merged

feat: add imageurl field in oob issuance and verification #64

merged 2 commits into from
Feb 26, 2024

Conversation

bhavanakarwade
Copy link
Contributor

@bhavanakarwade bhavanakarwade commented Feb 26, 2024 •
edited
Loading

What?

  • Added imageUrl field in connection invitation of oob create offer and oob request proof

@bhavanakarwade
feat: add imageurl field in oob issuance and verification
e431b84 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
feat: add imageurl in oob issuance and verification for dedicated agent
22d9934 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
11.8% Duplication on New Code

See analysis details on SonarCloud

sairanjit
sairanjit approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@sairanjit sairanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sairanjit sairanjit merged commit 85b0d42 into main Feb 26, 2024
5 checks passed
@sairanjit sairanjit deleted the imageUrl-issuance-verification-oob branch February 26, 2024 13:53
bhavanakarwade added a commit that referenced this pull request Mar 11, 2024
@bhavanakarwade
feat: add imageurl field in oob issuance and verification (#64)
c8e1cd9 
* feat: add imageurl field in oob issuance and verification

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: add imageurl in oob issuance and verification for dedicated agent

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
GHkrishna pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade @GHkrishna
feat: add imageurl field in oob issuance and verification (#64)
d2a0f2a 
* feat: add imageurl field in oob issuance and verification

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: add imageurl in oob issuance and verification for dedicated agent

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
GHkrishna pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade @GHkrishna
feat: add imageurl field in oob issuance and verification (#64)
ffd5fb8 
* feat: add imageurl field in oob issuance and verification

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: add imageurl in oob issuance and verification for dedicated agent

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 13, 2024
@bhavanakarwade @KulkarniShashank
feat: add imageurl field in oob issuance and verification (#64)
f0da506 
* feat: add imageurl field in oob issuance and verification

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: add imageurl in oob issuance and verification for dedicated agent

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 13, 2024
@bhavanakarwade @KulkarniShashank
feat: add imageurl field in oob issuance and verification (#64)
6b5814b 
* feat: add imageurl field in oob issuance and verification

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: add imageurl in oob issuance and verification for dedicated agent

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
GHkrishna pushed a commit that referenced this pull request Sep 13, 2024
@bhavanakarwade @GHkrishna
feat: add imageurl field in oob issuance and verification (#64)
7825560 
* feat: add imageurl field in oob issuance and verification

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* feat: add imageurl in oob issuance and verification for dedicated agent

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sairanjit sairanjit sairanjit approved these changes

@ankita-p17 ankita-p17 Awaiting requested review from ankita-p17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhavanakarwade @sairanjit