Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pagination and sorting for connections, issuance, and verification #343

Merged
merged 14 commits into from
Dec 13, 2023
Merged

feat: Pagination and sorting for connections, issuance, and verification #343

merged 14 commits into from
Dec 13, 2023

Conversation

bhavanakarwade
Copy link
Contributor

What

  • Modified POST API of webhook connection to create connection.
  • Developed GET API for fetching connections list from database and applied pagination, searching and sorting on it.
  • Modified POST API of webhook connection to create issue-credential.
  • Developed GET API for fetching issued-credentials list from database and applied pagination, searching and sorting on it.
  • Modified POST API of webhook connection to create proof-presentation.
  • Developed GET API for fetching proof-presentations list from database and applied pagination, searching and sorting on it.
  • Masked wallet label name while storing in database.

Why

  • To retrieve connections, issued credentials and proof presentation lists from the database, including features such as pagination, searching and sorting for enhanced usability and efficiency in managing these records.

@bhavanakarwade
refactor: get api of connection
e3434fe 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
refactor: get API of fetch all connection
da1f273 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into so…
c3115fc 
…rting-pagination
@bhavanakarwade
feat: added pagination and sorting features
0023469 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into so…
40b22e1 
…rting-pagination
@bhavanakarwade
feat: applied pagination and sorting feature for connections issuance…
231ea7a 
… and verification

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into so…
8467cd5 
…rting-pagination
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into so…
cf5a386 
…rting-pagination
@bhavanakarwade
feat: masked pi data
870e454 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into so…
4c0d566 
…rting-pagination
@bhavanakarwade
feat: applied pagination and sorting
35595ae 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade bhavanakarwade added the enhancement New feature or request label Dec 13, 2023
@bhavanakarwade bhavanakarwade self-assigned this Dec 13, 2023
@bhavanakarwade bhavanakarwade linked an issue Dec 13, 2023 that may be closed by this pull request
Develop GET APIs of connection, issuance and verification (backend) #312
Closed
6 tasks
@bhavanakarwade
resolved sonarlint checks
2e58301 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
removed unnecessary code
7d28e9f 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into so…
89ec8ba 
…rting-pagination
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

KulkarniShashank
KulkarniShashank approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KulkarniShashank KulkarniShashank merged commit abcda45 into develop Dec 13, 2023
2 checks passed
@nishad-ayanworks nishad-ayanworks changed the title feat: applied pagination and sorting feat: Pagination and sorting for connections, issuance, and verification Dec 29, 2023
@bhavanakarwade bhavanakarwade deleted the sorting-pagination branch March 7, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KulkarniShashank KulkarniShashank KulkarniShashank approved these changes

Assignees

@bhavanakarwade bhavanakarwade

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop GET APIs of connection, issuance and verification (backend)
2 participants
@bhavanakarwade @KulkarniShashank