Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: endorsement list and request endorsement for schema #324

Merged
merged 22 commits into from
Oct 10, 2023

Conversation

sanjay-k1910
Copy link
Contributor

What?

  • Implemented Endorsement list
  • Implemented request endorsement for schema
  • Added sidebar option as per roles and ecosystem enable flag
  • Implemented confirm popup custom component
  • Implemented endorsement card
  • Implemented endorsement popup
  • Implemented endorsement list page and handled with roles
  • Handled form and button label for creating schema
  • Added getEcosystemId function

sanjay-k1910 and others added 17 commits October 5, 2023 17:04
…e and flag, created custom function for ecosystem role check

Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
…-endorsement

Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: MoulikaKulkarni <moulika.kulkarni@ayanworks.com>
Signed-off-by: MoulikaKulkarni <moulika.kulkarni@ayanworks.com>
Signed-off-by: MoulikaKulkarni <moulika.kulkarni@ayanworks.com>
Signed-off-by: MoulikaKulkarni <moulika.kulkarni@ayanworks.com>
… custom component

Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
…into ecosystem-endorsement-popups

Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
…ed and updated sidebar code

Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
…-endorsement

Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
…-endorsement

Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
…-endorsement

Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
Signed-off-by: sanjay-k1910 <sanjay.khatal@ayanworks.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
1.7% 1.7% Duplication

isProcessing: boolean
}

const ConfirmModal = (props: IProps) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please be specific for the model name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a custom confirmation popup and we can use it anywhere in our code.
Can you please suggest a better name?

// const handleFilter = (e: React.ChangeEvent<HTMLSelectElement>) => {
// console.log("Handle filter", e.target.value)
// if (e.target.value === 'All schemas') {
// setAllSchemaFlag(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this code needed for other development

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as we discussed, the Schema list does not require any filter for now as we are showing all the schemas created under ecosystems. So, for now, we can keep this code as it is. I'll remove this code in my next PR after discussion.

Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comments

@nishad-ayanworks nishad-ayanworks merged commit 825e75a into develop Oct 10, 2023
6 checks passed
@sanjay-k1910 sanjay-k1910 deleted the feat-endorsement branch November 3, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants