Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not show change when user select a different offer [28823] #57

Merged
merged 2 commits into from
Aug 7, 2022
Merged

Not show change when user select a different offer [28823] #57

merged 2 commits into from
Aug 7, 2022
+66 −12

Conversation

lqgioan
Copy link
Contributor

@lqgioan lqgioan commented Aug 7, 2022

Description

  • I fixed issue in the ticket by adding missing fields in the offer object

Motivation & Context

Ticket: https://app.shortcut.com/credify/story/28823/android-ios-not-show-change-when-user-select-a-different-offer

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@lqgioan lqgioan requested a review from ngo275 August 7, 2022 00:30
@ngo275 ngo275 merged commit 45fcb10 into development Aug 7, 2022
@ngo275 ngo275 deleted the gioanle/sc-28823-android-ios-not-show-change-when-user-select branch August 7, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngo275 ngo275 ngo275 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqgioan @ngo275