feat: allow to set storybook's globals #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wKich
reviewed
Jan 13, 2021
wKich
reviewed
Jan 13, 2021
zhzz
force-pushed
the
feature/set-globals
branch
from
f4c6218
to
7eee208
Compare
wKich
previously approved these changes
Jan 13, 2021
wKich
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил возможность передать в браузеры значения Globals. Это глобальные и изменяемые настройки в storybook@6+, которые доступны в декораторах и историях. Их можно менять в любой момент, истории автоматически ререндерятся.
Например, с помощью Globals и соответствующего декоратора можно настроить тему для всех компонентов сразу. И переключать ее в любой момент из аддона или тулбара (см. примеры по ссылке).
Правка позволяет pазным браузерам задавать разные значения. Что дает возможность тестировать разные темы параллельно на одном инстансе сторибука. Это очень актуально для retail-ui, где мы уже вплотную приблизились к запуску четырех сторибуков с разными настройками для тестирования четырех разных тем.