Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: RewardAllocation accepts target denom #376 #80

Merged
merged 4 commits into from
Oct 20, 2022
Merged

feat: RewardAllocation accepts target denom #376 #80

merged 4 commits into from
Oct 20, 2022

Conversation

kingcre
Copy link
Contributor

@kingcre kingcre commented Oct 20, 2022 •
edited
Loading

Description

Tasks

References

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hallazzang @kingcre
feat: RewardAllocation can specify target denom (cherry-picked)
b15d4cf 
this enables the migration of legacy farming plans from x/farming.

(cherry picked from commit 471f24dd29a2d514ffd689e19365051abe180eac)
@hallazzang @kingcre
docs: revise docs to reflect changes in reward allocation
153e542 
(cherry picked from commit 85cb7209bdde41d9d025c3503bfedf33d03fd030)
@hallazzang @kingcre
fix: use strings.Cut (cherry-picked)
a2cee9b 
(cherry picked from commit fe56f5d5fccc40b8cdae352c4c30f53f749ea763)
@kingcre kingcre self-assigned this Oct 20, 2022
@github-actions github-actions bot added documentation Improvements or additions to documentation x/farm labels Oct 20, 2022
@kingcre kingcre marked this pull request as ready for review October 20, 2022 12:39
queencre
queencre approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@queencre queencre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kingcre kingcre merged commit a51ca0a into main Oct 20, 2022
@kingcre kingcre deleted the cherry-pick/376 branch August 1, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queencre queencre queencre approved these changes

@crypin crypin Awaiting requested review from crypin crypin is a code owner

Assignees

@kingcre kingcre

Labels
documentation Improvements or additions to documentation x/farm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kingcre @queencre @hallazzang