Modified parsing of eventcode in relayAsyncEvents #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Bit busy today, so I'll look when I can. I don't have good integration treats for the events admittedly, so I'll probably write one at least for this event specifically. |
|
Merged, still doing some tests tho. Ok, I misinterpreted my own output, it's properly multiline. Writing tests. |
cretz
added a commit
that referenced
this pull request
Jul 24, 2018
|
Ok, shiny new HS_DESC_CONTENT test added. Thanks for the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8
The eventcode HS_DESC_CONTENT is followed by a space and then a bunch of other data, but the code currently assumes that the eventcode is just followed by a newline. The current change fixes this for the eventcode in question, however i haven't tested this with many other events, so not 100% sure if this breaks anything.