Catch BaseException in activities

Fixes temporalio#333
cretz · Jul 17, 2023 · 1fbe074 · 1fbe074
1 parent 83bbc36
commit 1fbe074
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/temporalio/worker/_activity.py b/temporalio/worker/_activity.py
@@ -436,12 +436,7 @@ async def _run_activity(
             completion.result.completed.result.CopyFrom(
                 (await self._data_converter.encode([result]))[0]
             )
-        except (
-            Exception,
-            asyncio.CancelledError,
-            temporalio.exceptions.CancelledError,
-            temporalio.activity._CompleteAsyncError,
-        ) as err:
+        except BaseException as err:
             try:
                 if isinstance(err, temporalio.activity._CompleteAsyncError):
                     temporalio.activity.logger.debug("Completing asynchronously")