-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] BaseException exceptions are not caught when raised in an activity #333
Comments
I think you've written invalid Python code. I haven't tested yet, but I think |
Ahh this one's a typo - on mobile for the next few days 😅. Apologies, amending - the source is the later |
Ok, I see the issue. We intentionally only catch
And from https://docs.python.org/3/tutorial/errors.html#handling-exceptions:
I'm not sure we want to trap In the meantime, please derive from |
Gotcha - yep it's an upstream IMO, crashing the worker seems overkill - maybe a |
What are you really trying to do?
Describe the bug
The bug occurs when raising custom exceptions during an activity. the system raises
TypeError -> exception causes must derive from BaseException
, which overshadows the actual errorMinimal Reproduction
Environment/Versions
The text was updated successfully, but these errors were encountered: