Refactor handling of MIR bodies #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xldenis
reviewed
May 4, 2023
xldenis
reviewed
May 4, 2023
Comment on lines
+42
to
+46
| pub struct BodyId { | ||
| def_id: LocalDefId, | ||
| pub promoted: Option<Promoted>, | ||
| } | ||
|
|
There was a problem hiding this comment.
FINALLY, GOOD, THANKS. Incidentally, I've seen discussions about giving promoteds their own DefIds but this is good.
xldenis
reviewed
May 4, 2023
xldenis
reviewed
May 4, 2023
| ) -> CreusotResult<(PreSignature<'tcx>, fmir::Body<'tcx>)> { | ||
| let func_translator = BodyTranslator::build_context(ctx.tcx, ctx, &body, parent); | ||
| let body = ctx.body(body_id).clone(); |
There was a problem hiding this comment.
I wish we didn't have to clone the body here but if that turns out to be a perf issue later, we can always either wrap it in an Rc or use interior mutability in ctx like rustc does.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables translating const fns.