Carthage support #16
Merged
Carthage support #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daichiro
commented
Dec 8, 2016
| @@ -20,6 +20,7 @@ extension ActionScene { | |||
| } | |||
| guard let sceneContents = manager.getStuff(scene: self) as? (SceneDirector<TransitionType>, ArgumentType?, SceneObserver) else { | |||
| assert(false, "Illegal Operation Error") | |||
| return nil | |||
There was a problem hiding this comment.
guard needs return in else statement
|
I'm sorry that I've never used carthage before. |
crexista
approved these changes
Dec 12, 2016
| @@ -20,6 +20,7 @@ extension ActionScene { | |||
| } | |||
| guard let sceneContents = manager.getStuff(scene: self) as? (SceneDirector<TransitionType>, ArgumentType?, SceneObserver) else { | |||
| assert(false, "Illegal Operation Error") | |||
| return nil | |||
| $(SRCROOT)/carthage/Build/iOS/KabuKit.framework | ||
| $(SRCROOT)/carthage/Build/iOS/RxSwift.framework # if you've not added | ||
| ``` | ||
|
|
|
#16 (comment) |
|
OK. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @crexista
When this PR is merged, we can install this repo with Carthage.
I created Shared Scheme "KabuKit-iOS".