Expand variable and type parameter name #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstract:
- Set type parameter name as "${Target}Type"
- Set type parameter name (declared with `associatedtype` ) as "${Target}"
Note:
- This commit will break following thing.
- `ContextType` declared in `Scene` protocol.
- `ContextType` must be replaced with `Context` .
Abstract: - Expand few variable names - Make variable name more clear
Abstract: - Update `ContextType` to `Context`
Codecov Report
@@ Coverage Diff @@
## versions/0.4.0 #77 +/- ##
===============================================
Coverage 93.49% 93.49%
===============================================
Files 7 7
Lines 123 123
===============================================
Hits 115 115
Misses 8 8
Continue to review full report at Codecov.
|
crexista
reviewed
Jul 10, 2017
|
|
||
| fileprivate var dic = [String : Transitioning]() |
|
Please pass PR Builder check 🐱 |
Abstract: - Adds test cases for SceneSequenceTest, SceneTest, ScreenTest
|
Sorry for late. I added few test cases for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I would like to submit this PR for following features.
Note that, this PR contains an update written in
# Notesection. (Have effects to current codes)If possible, I want to discuss about this feature can be included or not.
Thanks.
Abstract
This PR changes following things
${Target}Typeassociatedtype) as${Target}Note
!!! Modifications in this PR breaks following parts.
ContextType->Context