-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Windows project #119
Conversation
kuleshov-aleksei
commented
Mar 16, 2018
- Update MSVS15 project
- Deleted gather.c from project
src/mqueue/mqueue.c
Outdated
#ifdef __linux__ | ||
#include <unistd.h> | ||
#endif | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of #ifdef linux, please use:
#ifdef HAVE_UNISTD_H
#include <unistd.h>
#endif
Now it is using HAVE_UNISTD_H instead of linux |
thanks. for some reason you changed the mqueue.c file from unix format to DOS format. the ccheck is failing: ./src/mqueue/mqueue.c:1: not in Unix format please change the file back to Unix format. the rest of the PR looks okay to me. |
Sorry, I didn't notice this. Now it changed back to Unix format |
this PR looks okay to me. @richaas please merge if you agree. |
src/mqueue/mqueue.c
Outdated
#include <unistd.h> | ||
#endif | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove extra blank line
@richaas this line is removed now |
this looks okay to me now. okay to merge ? |
I think those files was already in DOS format. I run this locally:
and git diff shows no difference. |
Yes, that's correct. That's why I removed my comment :-) |