Remove deprecated implicit hooks directory handling #2731
Conversation
If `hooks_dir` is unset, CRI-O will not longer default to `/usr/share/containers/oci/hooks.d` and `/etc/containers/oci/hooks.d` because this behavior is depcrecated since some releases. Documentation has been adapted as well. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
openshift-ci-robot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
/test integration_fedora |
|
LGTM |
|
/retest |
|
/lgtm |
|
/retest |
|
/cherry-pick release-1.16 |
|
@haircommander: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/cri-o\n ! [remote rejected] cherry-pick-2731-to-release-1.16 -> cherry-pick-2731-to-release-1.16 (cannot lock ref 'refs/heads/cherry-pick-2731-to-release-1.16': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/cri-o'\n", error: exit status 1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@haircommander: new pull request created: #2802 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
We're seeing regressions by the changed behavior as some deployments were relying on these defaults. To be fair, CRI-O has been warning about the deprecation for almost a year but the fact we're regressing shows that warnings are not enough and that we didn't scream about this when releasing so package updates and/or config managers can properly set the This PR is just pulling the trigger of an earlier decision and doesn't deserve any blame but I still wanted to share the impact. |
In CRI-O we moved to not using implicit hooks dirs (cri-o/cri-o#1943, cri-o/cri-o#2731). Unfortunately, we never set a default, until: cri-o/cri-o#3011. The default isn't enough, though. We also need /etc/containers/oci/hook.d because /usr is immutable, so a user can't add hooks. Signed-off-by: Peter Hunt <pehunt@redhat.com>
In CRI-O we moved to not using implicit hooks dirs (cri-o/cri-o#1943, cri-o/cri-o#2731). Unfortunately, we never set a default, until: cri-o/cri-o#3011. The default isn't enough, though. We also need /etc/containers/oci/hook.d because /usr is immutable, so a user can't add hooks. Signed-off-by: Peter Hunt <pehunt@redhat.com>
If
hooks_diris unset, CRI-O will not longer default to/usr/share/containers/oci/hooks.dand/etc/containers/oci/hooks.dbecause this behavior is depcrecated since some releases.
Documentation has been adapted as well.