Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] Remove deprecated implicit hooks directory handling #2802

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2731

/assign haircommander

If `hooks_dir` is unset, CRI-O will not longer default to
`/usr/share/containers/oci/hooks.d` and `/etc/containers/oci/hooks.d`
because this behavior is depcrecated since some releases.

Documentation has been adapted as well.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@openshift-ci-robot openshift-ci-robot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 14, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2019
@codecov
Copy link

codecov bot commented Sep 14, 2019

Codecov Report

Merging #2802 into release-1.16 will increase coverage by 0.03%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##           release-1.16    #2802      +/-   ##
================================================
+ Coverage         52.69%   52.72%   +0.03%     
================================================
  Files                85       85              
  Lines              7124     7118       -6     
================================================
- Hits               3754     3753       -1     
+ Misses             3007     3003       -4     
+ Partials            363      362       -1

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2019
Copy link
Contributor

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Contributor

rhatdan commented Sep 16, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. labels Sep 16, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9939243 into cri-o:release-1.16 Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants