New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.16] Remove deprecated implicit hooks directory handling #2802
[release-1.16] Remove deprecated implicit hooks directory handling #2802
Conversation
If `hooks_dir` is unset, CRI-O will not longer default to `/usr/share/containers/oci/hooks.d` and `/etc/containers/oci/hooks.d` because this behavior is depcrecated since some releases. Documentation has been adapted as well. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
Codecov Report
@@ Coverage Diff @@
## release-1.16 #2802 +/- ##
================================================
+ Coverage 52.69% 52.72% +0.03%
================================================
Files 85 85
Lines 7124 7118 -6
================================================
- Hits 3754 3753 -1
+ Misses 3007 3003 -4
+ Partials 363 362 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
This is an automated cherry-pick of #2731
/assign haircommander