Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go.mod to use go 1.13 #2957

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Bump go.mod to use go 1.13 #2957

merged 1 commit into from
Nov 11, 2019

Conversation

saschagrunert
Copy link
Member

To avoid inconsistent behavior between go versions we now use go 1.13 per
default.

@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 8, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 8, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 8, 2019
@saschagrunert saschagrunert force-pushed the gomod-bump branch 2 times, most recently from 768eb3f to 71d72ad Compare November 8, 2019 09:25
@rhatdan
Copy link
Contributor

rhatdan commented Nov 8, 2019

/retest

@TomSweeneyRedHat
Copy link
Contributor

Change LGTM, but the tests don't.

@haircommander
Copy link
Member

Failures are from an ansible bump causing the provisioning code to fail

@saschagrunert
Copy link
Member Author

Failures are from an ansible bump causing the provisioning code to fail

Is there anything I can do to solve this issue? Where did the ansible update happen?

@haircommander
Copy link
Member

I'm not really sure, I think our best bet is to fix the ansible ATM

@umohnani8
Copy link
Member

Could this help fix the failures I am seeing in #2947?

@haircommander
Copy link
Member

woah, gnarly. Yeah, it may

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2019 •
edited
Loading

@saschagrunert: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/critest_fedora 9f7a984 link /test critest_fedora
ci/openshift-jenkins/critest_rhel 9f7a984 link /test critest_rhel
ci/openshift-jenkins/e2e_features_fedora 9f7a984 link /test e2e_features_fedora
ci/openshift-jenkins/e2e_features_rhel 9f7a984 link /test e2e_features_rhel
ci/openshift-jenkins/e2e_fedora 9f7a984 link /test e2e_fedora
ci/openshift-jenkins/e2e_rhel 9f7a984 link /test e2e_rhel
ci/openshift-jenkins/integration_fedora 9f7a984 link /test integration_fedora
ci/openshift-jenkins/integration_rhel 9f7a984 link /test integration_rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saschagrunert
Bump go.mod to use go 1.13
509c3fd 
To avoid inconsistent behavior between go versions we now use go 1.13 per
default.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert mentioned this pull request Nov 11, 2019
Merged
@saschagrunert
Copy link
Member Author

@haircommander I think the focus for the e2e_features_* tests does not work any more. Are you already aware of this issue?

@haircommander
Copy link
Member

uhhh I don't know why that's happening. Through, e2e_features* don't test anything e2e* doesn't so it's not a huge loss. definitely something to look into though.

@saschagrunert
Copy link
Member Author

Test are green again, please take a look.

@haircommander
Copy link
Member

/lgtm

@haircommander
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2019
@haircommander
Copy link
Member

thanks prow

@openshift-merge-robot openshift-merge-robot merged commit 6ea0e8c into cri-o:master Nov 11, 2019
@saschagrunert saschagrunert deleted the gomod-bump branch November 11, 2019 16:28
@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 3, 2019
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@sameo sameo Awaiting requested review from sameo

@sboeuf sboeuf Awaiting requested review from sboeuf

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@saschagrunert @openshift-ci-robot @rhatdan @TomSweeneyRedHat @haircommander @umohnani8 @openshift-merge-robot