[release-1.18] oci: Don't return early for non-tty attach if there is no stdin #3813
Conversation
We want to return early from a non-tty attach only if stdin is enabled otherwise we want to wait for the output as well. Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
openshift-cherrypick-robot
requested review from
mrunalp and
runcom
as code owners
openshift-ci-robot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## release-1.18 #3813 +/- ##
=============================================
Coverage 40.51% 40.51%
=============================================
Files 105 105
Lines 8611 8611
=============================================
Hits 3489 3489
Misses 4811 4811
Partials 311 311 |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #3812
/assign haircommander