Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.20] Provide functionality to start infra containers on the specified set of CPUs #4469

Merged
merged 4 commits into from Jan 14, 2021
Merged

[1.20] Provide functionality to start infra containers on the specified set of CPUs #4469

merged 4 commits into from Jan 14, 2021

Conversation

haircommander
Copy link
Member

What type of PR is this?

/kind api-change
/kind bug
/kind ci
/kind cleanup
/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

cherry-pick of #4459

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Provide a new configuration flag to specify CPUs that will be used to run infra containers

Artyom Lukianov added 4 commits January 12, 2021 16:16
@haircommander
Add new infra-containers-cpus to the CLI and config file
b19b33a 
The new flag should provide a way to specify desired set
of CPUs used to run infra containers.

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@haircommander
Add shell completion for infra-containers-cpu flag
58d8a68 
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@haircommander
Set CPUs for the infra containers during the creation
21161a0 
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@haircommander
Provide integration test for infra-ctr-cpuset feature
c5c7082 
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 12, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2021
@haircommander
Copy link
Member Author

/retest

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #4469 (c5c7082) into release-1.20 (845747f) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.20    #4469      +/-   ##
================================================
- Coverage         40.62%   40.56%   -0.06%     
================================================
  Files               117      117              
  Lines              9404     9417      +13     
================================================
  Hits               3820     3820              
- Misses             5158     5169      +11     
- Partials            426      428       +2

@mrunalp
Copy link
Member

mrunalp commented Jan 12, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021
@giuseppe
Copy link
Member

/retest

4 similar comments
@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/retest e2e_aws

@openshift-ci-robot
Copy link

@haircommander: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test kata-containers
  • /test ami_fedora
  • /test ami_rhel
  • /test critest_fedora
  • /test critest_rhel
  • /test e2e_crun
  • /test e2e_cgroupv2
  • /test e2e_features_fedora
  • /test e2e_features_rhel
  • /test e2e_fedora
  • /test e2e_rhel
  • /test integration_crun
  • /test integration_cgroupv2
  • /test integration_fedora
  • /test integration_rhel
  • /test e2e-aws
  • /test images

Use /test all to run the following jobs:

  • kata-containers-crio-PR
  • test_pull_request_crio_critest_fedora
  • test_pull_request_crio_critest_rhel
  • test_pull_request_crio_e2e_crun_fedora
  • test_pull_request_crio_e2e_crun_fedora_cgroupv2
  • test_pull_request_crio_e2e_features_fedora
  • test_pull_request_crio_e2e_features_rhel
  • test_pull_request_crio_e2e_fedora
  • test_pull_request_crio_e2e_rhel
  • test_pull_request_crio_integration_crun_fedora
  • test_pull_request_crio_integration_crun_fedora_cgroupv2
  • test_pull_request_crio_integration_fedora
  • test_pull_request_crio_integration_rhel
  • pull-ci-cri-o-cri-o-release-1.20-e2e-aws
  • pull-ci-cri-o-cri-o-release-1.20-images

In response to this:

/retest e2e_aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

/test e2e-aws

1 similar comment
@mrunalp
Copy link
Member

mrunalp commented Jan 14, 2021

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 82b3148 into cri-o:release-1.20 Jan 14, 2021
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 2, 2021
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 17, 2021
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 13, 2021
Closed
@openshift-ci openshift-ci bot mentioned this pull request Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@sameo sameo Awaiting requested review from sameo

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@mrunalp mrunalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@haircommander @openshift-ci-robot @mrunalp @giuseppe @openshift-merge-robot